Merge all extensitons into one extension #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrjbq7
reviewed
Feb 4, 2017
talib/abstract.py
Outdated
|
|
||
| __ABSTRACT_FUNCTION_NAMES__ = ["_get_defaults_and_docs"] | ||
|
|
||
| _ta_func = __import__( |
There was a problem hiding this comment.
Why do you use __import__ instead of just import _ta_lib and use it directly?
There was a problem hiding this comment.
Yes.That's not necessary. I've changed this line and some other similar lines to import talib._ta_lib as _ta_lib.
mckelvin
force-pushed
the
merge-to-one-ext
branch
2 times, most recently
from
cfd42de to
30dac71
Compare
mckelvin
force-pushed
the
merge-to-one-ext
branch
from
30dac71 to
23b3dfc
Compare
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a broken-out part of #111, which aims to merge all extensitons (namely common, abstract, func, stream) into one extension (_ta_lib) Why? SEE: #110 (comment)
Advices for reviewer:
Cython 0.24.1to make sure they're just generated code.talib/_func.pxiandtalib/_stream.pxiare generated using corresponding scripts inside the tools directory, you can just review the scripts for generating and diff with the generated .pxi files.