Use MembershipScore.performance_total for sorting #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syriiin
force-pushed
the
use-new-membershipscore-pp
branch
from
b6f1c41 to
9e5799f
Compare
Syriiin
force-pushed
the
use-new-membershipscore-pp
branch
from
9e5799f to
09f5851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This should speed things up insanely.
Hopefully with this change we can get rid of the lb scores list cache.
Changes
Leaderboard.get_top_scores()andLeaderboard.get_pp_record()to use the newMembershipScore.performance_totalfield for sorting instead of doing potentially doing a case statement sort.Note
Need to make sure all
MembershipScorerows have populatedperformance_totalbefore deploying this