Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json mods field #172

Merged
merged 6 commits into from
Nov 30, 2024
Merged

Add json mods field #172

merged 6 commits into from
Nov 30, 2024

Conversation

Syriiin
Copy link
Owner

@Syriiin Syriiin commented Nov 30, 2024

Why?

We require json mods for full lazer support.

Changes

  • Add mods_json field to scores
  • Rename is_classic to is_stable and determine by legacy_score_id nullness
    • NOTE: Requires manual fix of is_stable=True score=0 scores (lazer scores using the CL mod wrongly marked as stable)
  • Add temporary backfilljsonmods command
  • Fix get_bitwise_mods not adding DT when NC is set (and for SD/PF)
    • NOTE: Requires manual fix of existing bitmods where NC/PF are set without DT/SD

@Syriiin Syriiin merged commit 1f46c84 into master Nov 30, 2024
4 checks passed
@Syriiin Syriiin deleted the add-json-mods branch November 30, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant