Split lb score cache task and implement dispatcher

Syriiin · Apr 15, 2024 · 4ca9ad1 · 4ca9ad1
1 parent fc8a711
commit 4ca9ad1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/leaderboards/tasks.py b/leaderboards/tasks.py
@@ -115,18 +115,25 @@ def send_notification(
 
 
 @shared_task
-def update_global_leaderboard_top_5_score_cache():
+def dispatch_update_global_leaderboard_top_5_score_cache():
     for gamemode in Gamemode:
         leaderboards = Leaderboard.objects.filter(
             access_type=LeaderboardAccessType.GLOBAL, gamemode=gamemode
         )
         for leaderboard in leaderboards:
-            scores = leaderboard.get_top_scores(limit=5)
-            cache.set(
-                f"leaderboards::global_leaderboard_top_5_scores::{leaderboard.id}",
-                scores,
-                1800,
-            )
+            update_global_leaderboard_top_5_score_cache.delay(leaderboard.id)
+
+
+@shared_task
+def update_global_leaderboard_top_5_score_cache(leaderboard_id: int):
+    leaderboard = Leaderboard.objects.get(id=leaderboard_id)
+    scores = leaderboard.get_top_scores(limit=5)
+    cache.set(
+        f"leaderboards::global_leaderboard_top_5_scores::{leaderboard.id}",
+        scores,
+        1800,
+    )
+    return scores
 
 
 @shared_task

diff --git a/osuchan/settings.py b/osuchan/settings.py
@@ -201,7 +201,7 @@ class EnvSettings(BaseSettings):
         "schedule": crontab(minute=0, hour=0),  # midnight UTC
     },
     "update-global-leaderboard-top-5-score-cache-every-20-minutes": {
-        "task": "leaderboards.tasks.update_global_leaderboard_top_5_score_cache",
+        "task": "leaderboards.tasks.dispatch_update_global_leaderboard_top_5_score_cache",
         "schedule": crontab(minute="*/20"),
     },
 }