Merge pull request #187 from Syriiin/fix/unrank-lazer-cl-mod

Fix lazer CL scores being ranked
Syriiin · Dec 15, 2024 · 026e1ae · 026e1ae
2 parents 304a434 + 610b36f
commit 026e1ae
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/common/osu/stubdata/osuapi/user_recent.json b/common/osu/stubdata/osuapi/user_recent.json
@@ -108,6 +108,34 @@
                 "perfect": false,
                 "rank": "A",
                 "date": "2024-12-14T11:41:59+00:00"
+            },
+            {
+                "beatmap_id": 386728,
+                "mods": 0,
+                "mods_json": {
+                    "CL": {}
+                },
+                "is_stable": false,
+                "score": 527683,
+                "best_combo": 269,
+                "count_300": 1276,
+                "count_100": 69,
+                "count_50": 0,
+                "count_miss": 20,
+                "count_katu": 0,
+                "count_geki": 0,
+                "statistics": {
+                    "ok": 69,
+                    "miss": 20,
+                    "great": 1276,
+                    "ignore_hit": 332,
+                    "ignore_miss": 9,
+                    "large_tick_hit": 40,
+                    "slider_tail_hit": 327
+                },
+                "perfect": false,
+                "rank": "A",
+                "date": "2024-12-14T11:42:00+00:00"
             }
         ],
         "1": [],

diff --git a/profiles/services.py b/profiles/services.py
@@ -339,9 +339,15 @@ def add_scores_from_data(user_stats: UserStats, score_data_list: list[ScoreData]
 
         if score.mods & Mods.UNRANKED != 0:
             continue
+
+        # Mod settings are currently unranked
         if any(settings != {} for settings in score.mods_json.values()):
             continue
 
+        # Lazer scores with CL are currently unranked
+        if not score.is_stable and "CL" in score.mods_json:
+            continue
+
         # Update foreign keys
         beatmap_id = score_data.beatmap_id
         try: