Merge pull request #27 from Syriiin/handle-zero-object-maps

Handle zero object maps by defaulting acc to 100%
Syriiin · Jun 7, 2024 · 0848c34 · 0848c34
2 parents ee6597b + 93ce210
commit 0848c34
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/Difficalcy.Catch/Services/CatchCalculatorService.cs b/Difficalcy.Catch/Services/CatchCalculatorService.cs
@@ -134,6 +134,9 @@ private static double CalculateAccuracy(Dictionary<HitResult, int> statistics)
             double hits = statistics[HitResult.Great] + statistics[HitResult.LargeTickHit] + statistics[HitResult.SmallTickHit];
             double total = hits + statistics[HitResult.Miss] + statistics[HitResult.SmallTickMiss];
 
+            if (total == 0)
+                return 1;
+
             return hits / total;
         }
 

diff --git a/Difficalcy.Mania/Services/ManiaCalculatorService.cs b/Difficalcy.Mania/Services/ManiaCalculatorService.cs
@@ -127,6 +127,9 @@ private static double CalculateAccuracy(Dictionary<HitResult, int> statistics)
             var countMiss = statistics[HitResult.Miss];
             var total = countPerfect + countGreat + countGood + countOk + countMeh + countMiss;
 
+            if (total == 0)
+                return 1;
+
             return (double)((6 * countPerfect) + (6 * countGreat) + (4 * countGood) + (2 * countOk) + countMeh) / (6 * total);
         }
 

diff --git a/Difficalcy.Osu/Services/OsuCalculatorService.cs b/Difficalcy.Osu/Services/OsuCalculatorService.cs
@@ -132,6 +132,9 @@ private static double CalculateAccuracy(Dictionary<HitResult, int> statistics)
             var countMiss = statistics[HitResult.Miss];
             var total = countGreat + countOk + countMeh + countMiss;
 
+            if (total == 0)
+                return 1;
+
             return (double)((6 * countGreat) + (2 * countOk) + countMeh) / (6 * total);
         }
 

diff --git a/Difficalcy.Taiko/Services/TaikoCalculatorService.cs b/Difficalcy.Taiko/Services/TaikoCalculatorService.cs
@@ -128,6 +128,9 @@ private static double CalculateAccuracy(Dictionary<HitResult, int> statistics)
             var countMiss = statistics[HitResult.Miss];
             var total = countGreat + countOk + countMiss;
 
+            if (total == 0)
+                return 1;
+
             return (double)((2 * countGreat) + countOk) / (2 * total);
         }