return extra lun info and allow create with direct_io_pattern #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great project! I've started to use the
dsm/webapi
module for a project of my own - a CLI for Synology iSCSI storage which you can see here.Two features I would love to have for my CLI are:
DevAttribs
along with the LUN info. My CLI allows creating a LUN with extra features like space reclamation and FUA/Sync cache. These are dev attributes which are already supported in theLunCreateSpec
. However I can't display whether an existing LUN has these enabled or not since the dev attributes are not returned by the get/list methods.0
which maps toBuffered I/O
. You can see this in the DSMSYNO.Core.ISCSI.LUN
API response from the second image below. A value of3
maps to theDirect I/O
option.This small PR adds both these features.