-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reg_f3d2 support #943
Draft
ALEXJAZZ008008
wants to merge
11
commits into
SyneRBI:master
Choose a base branch
from
ALEXJAZZ008008:niftyreg_velocity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add reg_f3d2 support #943
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e6472c9
added code to use reg_f3d2 in NiftyF3dSym which uses a velocity field…
ALEXJAZZ008008 14b0d7d
removed forward declaration
ALEXJAZZ008008 8b3facd
replaced forward declaration
ALEXJAZZ008008 5c96834
added ability to set number of bins for nmi
ALEXJAZZ008008 637bcb3
Merge branch 'master' of https://github.com/SyneRBI/SIRF into niftyre…
ALEXJAZZ008008 31354f5
fix for transformation types outside 1-3
ALEXJAZZ008008 b6947c0
compse was easier than initialisaing an object manually
ALEXJAZZ008008 b374f9d
added support for cpp and init from cpp
ALEXJAZZ008008 befc395
issue with def not initialised
ALEXJAZZ008008 81c848c
moving to change f3d to use non 3d image
ALEXJAZZ008008 2e956d3
set reg weight was wrong
ALEXJAZZ008008 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct?
create_from_cpp
always call this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct, this will only work with f3d2, I wrote it this way for speed of implementation. Really we should check to see if _use_velocity is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem being that _use_velocity is a member variable of NiftyF3dSym
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what you mean, but maybe this just needs 2 different functions
create_from_cpp
andcreate_from_velocity_field
. Or it needs some header inspection