Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OSEM step size rule #40

Closed
wants to merge 1 commit into from
Closed

add OSEM step size rule #40

wants to merge 1 commit into from

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Jul 5, 2024

Create and use the OSEM step size rule.

@KrisThielemans
Copy link
Member

I wouldn't put this in the ISTA example. It certainly makes very little sense to have both OSEM-type step-size (i.e. preconditioner) and the "kappa^2" preconditioner. It would be a good candidate for SIRF-Contrib though. We could conceivably have some OSEM implementations there: hand-crafted, using SIRF, using CIL.

By the way, I'm not sure if this should be a step-size or preconditioner. I guess with the current CIL code, there's little distinction anymore.

@casperdcl casperdcl force-pushed the main branch 3 times, most recently from 908c39a to 9900487 Compare July 10, 2024 17:41
@casperdcl casperdcl added the enhancement New feature or request label Jul 10, 2024
@casperdcl
Copy link
Member

shall we close this then?

@casperdcl casperdcl added the wontfix This will not be worked on label Jul 10, 2024
@KrisThielemans
Copy link
Member

Closing this as no intention to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants