Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISTA preconditioner #36

Merged
merged 5 commits into from
Jul 5, 2024
Merged

ISTA preconditioner #36

merged 5 commits into from
Jul 5, 2024

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Jul 4, 2024

added preconditioner.
Add kappa to the data

@paskino paskino requested a review from casperdcl July 4, 2024 10:36
KrisThielemans
KrisThielemans requested changes Jul 4, 2024
View reviewed changes
main_ISTA.py Outdated Show resolved Hide resolved
main_ISTA.py Outdated Show resolved Hide resolved
main_ISTA.py Outdated Show resolved Hide resolved
casperdcl
casperdcl reviewed Jul 4, 2024
View reviewed changes
main_ISTA.py Outdated Show resolved Hide resolved
@casperdcl casperdcl changed the title Precond ISTA preconditioner Jul 4, 2024
@casperdcl casperdcl added bug Something isn't working enhancement New feature or request labels Jul 4, 2024
@paskino @KrisThielemans @casperdcl
Apply suggestions from code review
fffc8bd 
Co-authored-by: Kris Thielemans <[email protected]>
Co-authored-by: Casper da Costa-Luis <[email protected]>
KrisThielemans
KrisThielemans approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go. @casperdcl or @paskino will you merge?

KrisThielemans
KrisThielemans requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you please add a header to the file describing what this is? Something like

This is an example of a stochastic subset version of preconditioned ISTA, implemented by using the CIL optimisation library.

@casperdcl casperdcl merged commit 4301b7c into main Jul 5, 2024
2 checks passed
@casperdcl casperdcl deleted the precond branch July 5, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans approved these changes

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@paskino paskino

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paskino @KrisThielemans @casperdcl