Skip to content

Commit

Permalink
Add TODO notes about conversion edge cases that need to be checked / …
Browse files Browse the repository at this point in the history
…handled
  • Loading branch information
jakebeal committed Oct 7, 2023
1 parent 79bc916 commit 3c4765a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sbol_utilities/sbol3_sbol2_conversion.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ def _convert(self, doc3: sbol3.Document):
# Try conversion, resetting saved parameter values afterward
try:
doc3.accept(self)
# TODO: make sure that complex extension objects (e.g., from SBOLFactory) are properly converted
# TODO: make sure that unhandled SBOL child objects / properties will throw errors
# TODO: check if we need to add post-creation fix-up of links, to ensure they point to objects
finally:
sbol2.Config.setOption(sbol2.ConfigOptions.SBOL_COMPLIANT_URIS.value, saved_compliance)
sbol2.setHomespace(saved_homespace)
Expand Down

0 comments on commit 3c4765a

Please sign in to comment.