Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #356 & reformat DT classes #355

Merged
merged 5 commits into from
Dec 15, 2024
Merged

fix #356 & reformat DT classes #355

merged 5 commits into from
Dec 15, 2024

Conversation

MCTian-mi
Copy link
Collaborator

@MCTian-mi MCTian-mi commented Dec 14, 2024 •
edited
Loading

As the title said.

@MCTian-mi
Copy link
Collaborator Author

suppresses #354

@MCTian-mi MCTian-mi changed the title fix #1160 & reformat DT classes fix #356 & reformat DT classes Dec 14, 2024
@MCTian-mi MCTian-mi marked this pull request as draft December 14, 2024 17:06
@MCTian-mi
Copy link
Collaborator Author

MCTian-mi commented Dec 14, 2024 •
edited
Loading

actually wait
weird, it works

@MCTian-mi MCTian-mi marked this pull request as ready for review December 14, 2024 17:10
@planetme planetme requested a review from bruberu December 14, 2024 18:09
@trainvoi
Copy link
Contributor

trainvoi commented Dec 14, 2024 •
edited
Loading

doesn't work on my instance
this only fixes the vacuum DT, the cryo DTs remain broken.

@MCTian-mi
Copy link
Collaborator Author

MCTian-mi commented Dec 15, 2024 •
edited
Loading

doesn't work on my instance this only fixes the vacuum DT, the cryo DTs remain broken.

how does it break? Does it not form or smth
nvm I didn't notice the controllers of some are on the 2nd layer. Should be fixed now

@trainvoi
Copy link
Contributor

did you fix the LP cryo DTs
also can you make the LP cryo DT extends upward.

@MCTian-mi
Copy link
Collaborator Author

did you fix the LP cryo DTs also can you make the LP cryo DT extends upward.

yeah I did give them custom handlers
I may ask planet whether LP cryo DT should extend upwards

@trainvoi
Copy link
Contributor

the LP cryo DT still doesn't work
HP cryo DT somehow only output 1 out of 3 fluids, 2 out of 2 fluids are voided
single column DT still voids output

@bruberu
Copy link
Member

bruberu commented Dec 15, 2024

My test world seems to have all of those working now, trainvoi?

@bruberu bruberu merged commit 390eae7 into SymmetricDevs:main Dec 15, 2024
1 check passed
trainvoi
trainvoi reviewed Dec 16, 2024
View reviewed changes
src/main/resources/assets/susy/lang/en_us.lang
@@ -759,6 +759,10 @@ gregtech.machine.fluid_hatch.export_9x.hv.name=HV Nonuple Output Hatch
gregtech.machine.dumping_hatch=Dumping Hatch
gregtech.machine.dumping_hatch.lv.name=Dumping Hatch

# Distillation tower explanations
gregtech.machine.ordered_dt.tooltip.1=Fluid input and output hatches are on the same layers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to "Fluid input and output hatches can be placed in the same layer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was considering this, but since you basically have to do that if you don't want to void items, I decided to pick "are" instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will get confusing for recipes with 2 inputs and 3 outputs tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruberu bruberu bruberu approved these changes

@trainvoi trainvoi trainvoi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCTian-mi @trainvoi @bruberu