select optimal params as those which maximise metric value, not just …

…largest parameters
SydneyBioX · Sep 17, 2024 · 694d193 · 694d193
1 parent 7c97929
commit 694d193
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/R/exploreWSIRParams.R b/R/exploreWSIRParams.R
@@ -115,8 +115,8 @@ exploreWSIRParams = function(exprs,
 
   chosen_metric_df <- res_df[(res_df$metric == metric),]
 
-  best_alpha = chosen_metric_df$alpha[which.max(chosen_metric_df$alpha)]
-  best_slices = chosen_metric_df$slices[which.max(chosen_metric_df$slices)]
+  best_alpha = chosen_metric_df$alpha[which.max(chosen_metric_df$value)]
+  best_slices = chosen_metric_df$slices[which.max(chosen_metric_df$value)]
 
   res_df$alpha <- res_df$alpha %>% as.factor()
   res_df$slices <- res_df$slices %>% as.factor()