Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URITemplate freestanding expression macro #81

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

alexdeem
Copy link
Member

@alexdeem alexdeem commented Dec 3, 2024

No description provided.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.68%. Comparing base (59dc884) to head (57c3264).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...lateCompilerPlugin/URITemplateCompilerPlugin.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #81      +/-   ##
===========================================
- Coverage    98.81%   98.68%   -0.13%     
===========================================
  Files            8       10       +2     
  Lines          506      531      +25     
===========================================
+ Hits           500      524      +24     
- Misses           6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexdeem alexdeem marked this pull request as draft December 3, 2024 11:49
@alexdeem
Copy link
Member Author

alexdeem commented Dec 3, 2024

This looks good, but codecov isn't seeing coverage data for the ScreamURITemplateCompilerPlugin target. 🤔
Converted to draft while investigating

@alexdeem alexdeem marked this pull request as ready for review December 3, 2024 22:37
@alexdeem
Copy link
Member Author

alexdeem commented Dec 3, 2024

This looks good, but codecov isn't seeing coverage data for the ScreamURITemplateCompilerPlugin target. 🤔 Converted to draft while investigating

resolved :)

@alexdeem alexdeem merged commit bbeca5c into develop Dec 3, 2024
5 checks passed
@alexdeem alexdeem deleted the macros branch December 3, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant