-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending the demo application with data objects #2
base: master
Are you sure you want to change the base?
Conversation
Hey, thanks @FDelporte! The first real PR for Supernaut! I like your general idea, and I would like to create a sample that is more full-fledged than what is currently in this repo. If you look in the main SupernautFX repository, you'll see that there are two sample apps and a test app. I put them in that repo for testing purposes -- so I can do a full build on single repository/Gradle multi project and make sure everything compiles, and links, and runs. But I also realize that having the projects in a Gradle multi-project makes them less accessible for people wanting to use the framework or looking for a template/starter project.
Maven/Gradle standalone repositories samples
My goals for the current Maven/Gradle standalone repositories sample:
Other, related goals:
I like that your changes inject a JavaFX model object ( With all this background info, I have two specific pieces of feedback on your PR:
What are you thoughts on any or all of these issues? |
thanks @msgilligan that's a whole lot of info! :-) |
Thanks, @FDelporte ! |
@FDelporte I'm thinking that it might be cool to add an "about this app" Model object to Supernaut.FX itself -- probably initially in the |
@msgilligan just a proposal to show the use of injection in a JavaFX application