Fix WiFi SSID long 32 gets wrongly truncated by one #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the string is null terminated so array size must be 33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum Wi-Fi SSID length is 32 characters, but if I try to connect to a network name which is exactly 32 characters long the last character gets truncated, eg: SSID:
533C Hyperoptic 1Gb Fibre 2.4Ghzgets truncated to533C Hyperoptic 1Gb Fibre 2.4Ghsince the SSID field in the structs of this project is defined as an array of size 32 but since it is a null terminated string, it should be defined as size 33...Fix wifi SSID length to 33 since the maximum chars for SSID is 32 but the string is null terminated so array size must be 33.
I have noticed this wrong behaviour using the esp_haa and reported in their forum: RavenSystem/esp-homekit-devices#1337 but it is not their fault...
Attached you can find my patch.