-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Config deserialization #193
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/return-data #193 +/- ##
====================================================
- Coverage 81.62% 81.32% -0.30%
====================================================
Files 7 14 +7
Lines 604 723 +119
Branches 110 164 +54
====================================================
+ Hits 493 588 +95
- Misses 108 131 +23
- Partials 3 4 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am personally not a fan of redefining the entire config structure in this library, it feels like that is doing too much.
Still approving because casparcg is developed slowly enough and there is a (albeit clunky) way of accessing untyped config.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adds deserialization to the response of INFO CONFIG
What is the current behavior? (You can also link to an open issue here)
Config is returned as
unknown
, unparsed.What is the new behavior (if this is a feature change)?
Config is parsed from XML to follow the
InfoConfig
interface, which is based on the config elements available in CasparCG 2.4. Any untyped, different or non-standard elements can be accessed throughraw
orrawXml
properties.Other information:
I'm opening this PR towards a feature branch that has already an open PR, so that my changes are easier to review on their own.