Issue #40 feat: Audio Upload Implementation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simran142002
changed the title
simran142002
changed the title
package.json
Outdated
| @@ -49,13 +49,16 @@ | |||
| "jquery": "^3.5.1", | |||
| "jquery.fancytree": "^2.37.0", | |||
| "karma-mocha-reporter": "^2.2.5", | |||
| "katex": "^0.11.1", | |||
There was a problem hiding this comment.
Why do we need katex library for this?
|
@simran142002 Please check the circle-ci issue and fix the same. |
| }) | ||
| export class AssetsBrowserComponent implements OnInit, OnChanges, OnDestroy { | ||
| @ViewChild('editor') public editorRef: ElementRef; | ||
| @Output() videoDataOutput = new EventEmitter<any>(); |
There was a problem hiding this comment.
Remove videoDataOutput variable if you not using it.
simran142002
force-pushed
the
feat/audioUpload
branch
from
bf20b25 to
da8eb99
Compare
|
@simran142002 Please check and fix the code smells. |
vaibhavbhuva
suggested changes
Sep 1, 2023
| export class AssetsBrowserComponent implements OnInit, OnChanges, OnDestroy { | ||
| @ViewChild('editor') public editorRef: ElementRef; | ||
| @Output() videoDataOutput = new EventEmitter<any>(); | ||
| @Output() editorDataOutput = new EventEmitter<any>(); |
There was a problem hiding this comment.
@simran142002 Still I can see there some variables are not being used by the component. Please check and remove the same.
There was a problem hiding this comment.
@simran142002 Why is this file needed, since we have the following file for mocking the data?
projects/questionset-editor-library/src/lib/components/assets-browser/assets-browser.component.spec.data.ts
vaibhavbhuva
approved these changes
Sep 4, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality:
Added Audio Upload functionality
Solution:
Sent audio as a parameter from question component to assets-browser component such that it can trigger the audio upload pop up and its corresponding mechanism
Risk level:
Issue:
#40
How to test:
nodemon server.js
npm run start