-
Notifications
You must be signed in to change notification settings - Fork 106
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #332 from holashchand/issue-988
[ISSUE-988]: Unit tests for registry and credential services to increase coverage
- Loading branch information
Showing
51 changed files
with
3,827 additions
and
2,204 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
186 changes: 186 additions & 0 deletions
186
java/registry/src/test/java/dev/sunbirdrc/registry/service/impl/AuditServiceImplTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| package dev.sunbirdrc.registry.service.impl; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||
| import com.fasterxml.jackson.databind.JsonNode; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import dev.sunbirdrc.pojos.AuditInfo; | ||
| import dev.sunbirdrc.pojos.AuditRecord; | ||
| import dev.sunbirdrc.registry.exception.AuditFailedException; | ||
| import dev.sunbirdrc.registry.helper.SignatureHelper; | ||
| import dev.sunbirdrc.registry.middleware.util.Constants; | ||
| import dev.sunbirdrc.registry.service.IAuditService; | ||
| import dev.sunbirdrc.registry.sink.shard.Shard; | ||
| import dev.sunbirdrc.registry.util.Definition; | ||
| import dev.sunbirdrc.registry.util.IDefinitionsManager; | ||
| import dev.sunbirdrc.registry.util.OSSystemFieldsHelper; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.mockito.InjectMocks; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockitoAnnotations; | ||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.test.context.ActiveProfiles; | ||
| import org.springframework.test.context.junit4.SpringRunner; | ||
|
|
||
| import java.io.IOException; | ||
| import java.lang.reflect.Field; | ||
| import java.util.List; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| @RunWith(SpringRunner.class) | ||
| @SpringBootTest(classes = {ObjectMapper.class}) | ||
| @ActiveProfiles(Constants.TEST_ENVIRONMENT) | ||
| public class AuditServiceImplTest { | ||
|
|
||
| @Value("${audit.enabled}") | ||
| private boolean auditEnabled; | ||
|
|
||
| @Value("${audit.frame.store}") | ||
| private String auditFrameStore; | ||
|
|
||
| @Value("${audit.frame.suffix}") | ||
| private String auditSuffix; | ||
|
|
||
| @Value("${audit.frame.suffixSeparator}") | ||
| private String auditSuffixSeparator; | ||
|
|
||
| @Value("${audit.vc-enabled:false}") | ||
| private boolean auditVCEnabled; | ||
|
|
||
| @Mock | ||
| private IDefinitionsManager definitionsManager; | ||
|
|
||
| @Mock | ||
| private OSSystemFieldsHelper systemFieldsHelper; | ||
|
|
||
| @Mock | ||
| private AuditProviderFactory auditProviderFactory; | ||
|
|
||
| @Mock | ||
| private SignatureHelper signatureHelper; | ||
|
|
||
| @Mock | ||
| private ObjectMapper objectMapper; | ||
|
|
||
| @InjectMocks | ||
| private AuditServiceImpl auditService; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| MockitoAnnotations.initMocks(this); | ||
| setField(auditService, "auditEnabled", auditEnabled); | ||
| setField(auditService, "auditFrameStore", auditFrameStore); | ||
| setField(auditService, "auditSuffix", auditSuffix); | ||
| setField(auditService, "auditSuffixSeparator", auditSuffixSeparator); | ||
| setField(auditService, "auditVCEnabled", auditVCEnabled); | ||
| } | ||
|
|
||
| private void setField(Object targetObject, String fieldName, Object value) throws Exception { | ||
| Field field = targetObject.getClass().getDeclaredField(fieldName); | ||
| field.setAccessible(true); | ||
| field.set(targetObject, value); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldAudit_ReturnsTrueWhenFileAuditEnabled() throws Exception { | ||
| setField(auditService, "auditFrameStore", Constants.FILE); | ||
| boolean result = auditService.shouldAudit("EntityType"); | ||
| assertTrue(result); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldAudit_ReturnsTrueWhenDBAuditEnabledAndDefinitionNotNull() throws Exception { | ||
| when(definitionsManager.getDefinition(anyString())).thenReturn(mock(Definition.class)); | ||
| setField(auditService, "auditFrameStore", Constants.DATABASE); | ||
| boolean result = auditService.shouldAudit("EntityType"); | ||
| assertTrue(result); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldAudit_ReturnsFalseWhenNoAuditingEnabled() throws Exception { | ||
| setField(auditService, "auditEnabled", false); | ||
| boolean result = auditService.shouldAudit("EntityType"); | ||
| assertFalse(result); | ||
| } | ||
|
|
||
| @Test | ||
| public void isAuditAction_ReturnsAuditActionForMatchingSuffix() { | ||
| String entityType = auditSuffix; | ||
| String action = auditService.isAuditAction(entityType); | ||
| assertEquals(Constants.AUDIT_ACTION_AUDIT, action); | ||
| } | ||
|
|
||
| @Test | ||
| public void isAuditAction_ReturnsSearchActionForNonMatchingSuffix() { | ||
| String entityType = "NonMatchingEntity"; | ||
| String action = auditService.isAuditAction(entityType); | ||
| assertEquals(Constants.AUDIT_ACTION_SEARCH, action); | ||
| } | ||
|
|
||
| @Test | ||
| public void createAuditInfo_ReturnsAuditInfoList() { | ||
| String auditAction = "AuditAction"; | ||
| String entityType = "EntityType"; | ||
| List<AuditInfo> auditInfoList = auditService.createAuditInfo(auditAction, entityType); | ||
|
|
||
| // Then | ||
| assertEquals(1, auditInfoList.size()); | ||
| assertEquals(auditAction, auditInfoList.get(0).getOp()); | ||
| assertEquals("/" + entityType, auditInfoList.get(0).getPath()); | ||
| } | ||
|
|
||
| @Test | ||
| public void convertAuditRecordToJson_ReturnsJsonNode() throws IOException { | ||
| // Given | ||
| AuditRecord auditRecord = new AuditRecord(); | ||
| JsonNode inputNode = mock(JsonNode.class); | ||
| Shard shard = mock(Shard.class); | ||
| String vertexLabel = "VertexLabel"; | ||
| when(objectMapper.writeValueAsString(any())).thenReturn("{}"); | ||
|
|
||
| // When | ||
| JsonNode result = auditService.convertAuditRecordToJson(auditRecord, vertexLabel); | ||
|
|
||
| // Then | ||
| assertNotNull(result); | ||
| assertTrue(result.has(vertexLabel)); | ||
| } | ||
|
|
||
| @Test | ||
| public void createAuditInfoWithJson_ReturnsAuditInfoListFromJson() throws JsonProcessingException { | ||
| // Given | ||
| String auditAction = "AuditAction"; | ||
| JsonNode differenceJson = mock(JsonNode.class); | ||
| String entityType = "EntityType"; | ||
| when(objectMapper.treeToValue(any(JsonNode.class), eq(AuditInfo[].class))) | ||
| .thenReturn(new AuditInfo[]{new AuditInfo()}); | ||
|
|
||
| // When | ||
| List<AuditInfo> auditInfoList = auditService.createAuditInfoWithJson(auditAction, differenceJson, entityType); | ||
|
|
||
| // Then | ||
| assertNotNull(auditInfoList); | ||
| assertEquals(1, auditInfoList.size()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDoAudit() throws AuditFailedException { | ||
| // Given | ||
| AuditRecord auditRecord = mock(AuditRecord.class); | ||
| JsonNode inputNode = mock(JsonNode.class); | ||
| Shard shard = mock(Shard.class); | ||
| IAuditService auditProvider = mock(IAuditService.class); | ||
|
|
||
| when(auditProviderFactory.getAuditService(anyString())).thenReturn(auditProvider); | ||
|
|
||
| // When | ||
| auditService.doAudit(auditRecord, inputNode, shard); | ||
|
|
||
| // Then | ||
| verify(auditProvider, times(1)).doAudit(auditRecord, inputNode, shard); | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.