Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue KN-961 feat: Updated player with angular version 15 #111

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c5b151d
Issue KN-961 feat: updated package lock file
HarishGangula Dec 1, 2023
25646f4
Merge remote-tracking branch 'upstream/release-6.0.0' into release-5.5.0
HarishGangula Dec 1, 2023
3bc0c71
Issue KN-961 feat: updated package lock file
HarishGangula Dec 1, 2023
1ffb892
Issue KN-961 feat: Angular version updated to 15
HarishGangula Dec 4, 2023
a2e0c16
Issue KN-961 feat: updated player versions
HarishGangula Dec 4, 2023
f541753
Issue KN-961 chore: updated node js version of circleci
HarishGangula Dec 4, 2023
824a271
Issue KN-961 feat: eslint ignore added
HarishGangula Dec 4, 2023
0da8a1f
Issue KN-961 chore: updated package lock file
HarishGangula Dec 4, 2023
3dfb00c
Issue #KN-961 feat:Updated eslint versions
HarishGangula Dec 4, 2023
ad444f7
Issue #KN-961 fix: updated the player dependences version
HarishGangula Jan 29, 2024
6905246
Issue #KN-961 fix: updated the player dependences version
HarishGangula Jan 30, 2024
26cacfe
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
5ba458d
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
38952ce
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
34dc8b6
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
2493a09
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
7dbbc86
Issue #KN-961 feat: updated the dependecy
HarishGangula Jan 30, 2024
c8f885d
Issue #KN-961 doc: updated the installation steps
HarishGangula Jan 30, 2024
d19d5b8
Issue #KN-961 feat: reverted image to LTS
HarishGangula Jan 30, 2024
d5a1653
Issue #KN-961 fix: updated angular json
HarishGangula Jan 30, 2024
fcd6532
Issue #KN-961 fix: updated angular json
HarishGangula Jan 30, 2024
c8567ef
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
24afae5
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
2452d1f
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
e26e481
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
761b318
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
3142b08
Issue #KN-961 feat: updated the circleci image to latest
HarishGangula Jan 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@ jobs:
build:
working_directory: ~/sunbird-pdf-player
docker:
- image: circleci/node:14.18.2-browsers
- image: cimg/node:20.11.0-browsers
steps:
- checkout:
path: ~/sunbird-pdf-player
- run:
name: Show current branch
command: echo ${CIRCLE_BRANCH}
- run:
name: add chromium
command: npm i puppeteer --legacy-peer-deps
- run:
environment:
NG_CLI_ANALYTICS: "ci"
command: npm install
- run: cd projects/sunbird-pdf-player && sudo npm install
- run:
name: Node install
command: sudo npm install
command: npm install --legacy-peer-deps
- run: cd projects/sunbird-pdf-player && npm install && npx audit-ci@^6 --config ./audit-ci.jsonc
- run:
name: Linting
command: npm run lint
Expand Down
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
**/node_modules
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### Note:
This version of the angular library is compatilbe with angular version 15 and may not work with older versions of the angular 15 Apps.

## The PDF player for the Sunbird!

The PDF player library is powered by Angular. This player is primarily designed to be used on Sunbird consumption platforms _(mobile app, web portal, offline desktop app)_ to drive reusability and maintainability, hence reducing the redundant development effort significantly, and it can be integrated with any platform irrespective of the platforms and the frontend frameworks. It is exported not only as an angular library but also as a web component. 
Expand All @@ -15,12 +18,6 @@ Follow below-mentioned steps to use it in plain javascript project:
```javascript
<script type="text/javascript" src="sunbird-pdf-player.js"></script>
```
- Update below script in index.html file
```javascript
<script src="https://cdnjs.cloudflare.com/ajax/libs/reflect-metadata/0.1.13/Reflect.min.js"
integrity="sha512-jvbPH2TH5BSZumEfOJZn9IV+5bSwwN+qG4dvthYe3KCGC3/9HmxZ4phADbt9Pfcp+XSyyfc2vGZ/RMsSUZ9tbQ=="
crossorigin="anonymous" referrerpolicy="no-referrer"></script>
```

- Get sample playerConfig from here: [playerConfig](https://github.com/Sunbird-Knowlg/sunbird-pdf-player/blob/release-5.5.0/src/app/data.ts)

Expand Down
3 changes: 2 additions & 1 deletion angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@
"./node_modules/@project-sunbird/sb-styles/assets/_styles.scss"
],
"scripts": [
"node_modules/@project-sunbird/telemetry-sdk/index.js"
"node_modules/@project-sunbird/telemetry-sdk/index.js",
"node_modules/reflect-metadata/Reflect.js"
],
"vendorChunk": true,
"extractLicenses": false,
Expand Down
1 change: 1 addition & 0 deletions build-wc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const build = async () => {
const files = [
"./dist/pdf-player-wc/runtime.js",
"./dist/pdf-player-wc/polyfills.js",
"./dist/pdf-player-wc/scripts.js",
"./dist/pdf-player-wc/vendor.js",
"./dist/pdf-player-wc/main.js"
];
Expand Down
Loading