Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct remove #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

correct remove #2

wants to merge 4 commits into from

Conversation

papasax
Copy link

@papasax papasax commented Dec 12, 2014

Hi,

I had troubles to set the draggable option so i chnaged the code to compare strings, and i corrected a bug to remove items from the list when they are destroyed.

regards,

Alex

@joshuahiggins
Copy link
Contributor

Thanks for the input Alex.

Can you open a Github issue describing the draggable problem you are having? I am having trouble understanding what problem would arise from using a truthy vs. explicit check for the draggable option.

I opened issue #3 to address the proposed unpack enhancement.

@joshuahiggins
Copy link
Contributor

I see you added some more commits, but I'm still not sure of the issue you are having. Can you provide a demo of the problem you are having?

Unpacking / destroying is a feature that I'd like to see added in v1.1, but I'd be happy to address any bugs in an upcoming 1.0.x patch.

@papasax
Copy link
Author

papasax commented Jan 13, 2015

Hi,

I tried to use your library like this:

and it was stil asking for the draggable library, so i changed the
code for this. What do you mean by truthy? Is there any correct way to
do this that I missed?

Concerning the unpack, i'm not sure if what i did is the correct way.
It works but i had to trap an error message coming from packery. If
you make a new version with those options i would be pleased to try
it.

Regards,

2015-01-13 17:46 GMT+01:00 Josh Higgins [email protected]:

I see you added some more commits, but I'm still not sure of the issue you
are having. Can you provide a demo of the problem you are having?

Unpacking / destroying is a feature that I'd like to see added in v1.1, but
I'd be happy to address any bugs in an upcoming 1.0.x patch.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants