-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jurisdiction to canonical form URLs #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it's still getting a build error. I'll pick this up again tomorrow. |
@nonprofittechy This is finally ready for you to review. Also I realized I could just run the tests locally, so future PRs shouldn't have so many attempted fixes. |
nonprofittechy
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates form URLs so they included the jurisdiction in the path (i.e.,
/ma/forms/[form-slug]
).There are a few other notable changes related to this:
/ma/forms
./ma
, it shows All MA Forms and points to/ma/forms
.When we do add non-MA jurisdictions we will want to revisit the UI and navigation. Right now the site is capable of displaying jurisdiction-specific pages, but it could use some clearer navigation to get up and down the tree.
Closes #66