Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jurisdiction to canonical form URLs #69

Merged
merged 19 commits into from
Sep 11, 2024

Conversation

samglover
Copy link
Contributor

This updates form URLs so they included the jurisdiction in the path (i.e., /ma/forms/[form-slug]).

There are a few other notable changes related to this:

  • I added a .name property to the pathToServerConfig object in formSources.config.js we could use the full name of the jurisdiction on its landing page, for example "All Massachusetts Forms" on /ma/forms.
  • The All Forms link in the header changes when a jurisdictions is being displayed. For example, when viewing /ma, it shows All MA Forms and points to /ma/forms.

When we do add non-MA jurisdictions we will want to revisit the UI and navigation. Right now the site is capable of displaying jurisdiction-specific pages, but it could use some clearer navigation to get up and down the tree.

Closes #66

@samglover
Copy link
Contributor Author

Looks like it's still getting a build error. I'll pick this up again tomorrow.

@samglover
Copy link
Contributor Author

@nonprofittechy This is finally ready for you to review. Also I realized I could just run the tests locally, so future PRs shouldn't have so many attempted fixes.

@samglover samglover merged commit ef7d087 into main Sep 11, 2024
2 checks passed
@samglover samglover deleted the add_jurisdiction_to_canonical_form_urls branch September 11, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canonical link for each form should be specific to one or more jurisdictions
2 participants