-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9 interview card data #24
Conversation
@nonprofittechy We acknowledge that the .yarn/cache makes these PRs very unwieldy. That's the current yarn best practice right now though. See https://github.com/yarnpkg/berry?tab=readme-ov-file#building-your-own-bundle. We recommend unchecking zip files from the file list. |
No worries about the .zip files. I had some trouble running this branch locally but I'll come back with a more specific question. |
Anything I can help out with getting it to run locally? |
So I did both a Maybe I'm having trouble understanding what the new routes are? |
Routes should be unchanged and you should still see the homepage on localhost:3000/ |
.filter( | ||
(topic) => | ||
topic.always_visible || | ||
(interviewsByTopic[topic.name] && | ||
interviewsByTopic[topic.name].length > 0) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good except we need to parse the LIST topics.
Edit: I suggest a function to see if a topic is contained in or is identical to a top level topic. The current site has some lower-level topics that we promoted to the "top" level, such as Appeals and Domestic Violence. So it's not just enough to strip off all of the numbers.
This PR addresses issue 19 as well as issue 21
Changes: