Craft node configuration #581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This system is more expandable, gives more examples to users looking to use the system themselves, and you should always use your own API
The feature was being complained about and called a bug very often, and because the bug it exists to fix is a minor one, and this itself arguably goes against the "don't edit the vanilla game" aspect of nautilus, it's only right to make it configurable
Probably not ideal but I don't feel like rummaging through the attributes code to grab a reference to the ModOptions manually, and this only runs once per session anyway so who cares
Just throw nautilus back to the top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request
Add a configuration option for hiding tab nodes, as this was a feature intended to workaround a minor issue and many users have since complained about this and considered it a bug. It arguably goes against the very thing it was intended to fix, that being keeping nautilus from doing unnecessary changes to the base game. While this doesn't affect the base game, it does quickly affect many mods, especially those in the modification station or cyclops upgrade fabricator. On top of that, many users use the popular Radial Tabs mod, which completely bypasses the need for this fix anyway as Radial Tabs has no possibility of any node overlap. Also moves the ugui_craftingmenu patches into their own file, which is where they should've been placed from the beginning
Breaking changes
None
Based off of the configuration overhaul in #580
I don't know if I did that right tbh, I couldn't even find out how to base the branch on my fork, so I had to just pr from my master branch back to this branch to get the new commit. If not, easy fix by just copying the code its not much.