-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench Organization. #486
Merged
Metious
merged 9 commits into
SubnauticaModding:master
from
MrPurple6411:CraftTreePatcherModifications
Oct 25, 2023
Merged
Workbench Organization. #486
Metious
merged 9 commits into
SubnauticaModding:master
from
MrPurple6411:CraftTreePatcherModifications
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all Crafting Nodes out of the Workbench Root Added a Fallback Node when adding craftnodes and they fail due to mixing tabs and crafting nodes. Created a TraverseTree method as we seem to be doing the same thing in multiple places. Added logging to ModCraftTreeRoot to show what nodes are in the way when trying to add a node fails due to cross node type.
Add CreateVanillaTabNode for all 3 fabricators that have no tabs. Add fallback tabs for all vanilla fabricators. Added the ability for Mods to remove and move other mods nodes by doubling down on the removals to before and after mod node creation. If a mod item fails the tab/crafting check it now gets put into the fallback unsorted tab with a warning.
…me new modded subnode
Metious
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment on something that looked a bit strange to me.
I've tested this PR in-game and it seems to be working fine.
Metious
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull request