Merge pull request #104 from Strong-Potato/bugfix/#103-add-generics-i…

…n-apiresponse [Bugfix] ApiResponse에 제네릭을 추가한다.
Strong-Potato · Jan 16, 2024 · bebcc8d · bebcc8d
2 parents a0c62d5 + 1f7fee1
commit bebcc8d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/app/src/main/java/fc/be/app/domain/review/controller/ReviewController.java b/app/src/main/java/fc/be/app/domain/review/controller/ReviewController.java
@@ -22,7 +22,7 @@ public ApiResponse<ReviewCreateResponse> createReview(@Valid @RequestBody Review
     }
 
     @PatchMapping
-    public ApiResponse<ReviewCreateResponse> editReview(@Valid @RequestBody ReviewEditRequest reviewEditRequest) {
+    public ApiResponse<ReviewEditResponse> editReview(@Valid @RequestBody ReviewEditRequest reviewEditRequest) {
         return ApiResponse.ok(reviewService.editReview(reviewEditRequest));
     }
 

diff --git a/app/src/main/java/fc/be/app/global/http/ApiResponse.java b/app/src/main/java/fc/be/app/global/http/ApiResponse.java
@@ -11,19 +11,19 @@ public record ApiResponse<T>(
     private static final HttpStatus CREATED = HttpStatus.CREATED;
     private static final String DEFAULT_MESSAGE = "SUCCESS";
 
-    public static ApiResponse ok() {
-        return new ApiResponse(OK.value(), DEFAULT_MESSAGE, null);
+    public static ApiResponse<Void> ok() {
+        return new ApiResponse<>(OK.value(), DEFAULT_MESSAGE, null);
     }
 
-    public static <T> ApiResponse ok(T data) {
-        return new ApiResponse(OK.value(), DEFAULT_MESSAGE, data);
+    public static <T> ApiResponse<T> ok(T data) {
+        return new ApiResponse<>(OK.value(), DEFAULT_MESSAGE, data);
     }
 
-    public static ApiResponse created() {
-        return new ApiResponse(CREATED.value(), DEFAULT_MESSAGE, null);
+    public static ApiResponse<Void> created() {
+        return new ApiResponse<>(CREATED.value(), DEFAULT_MESSAGE, null);
     }
 
-    public static <T> ApiResponse created(T data) {
-        return new ApiResponse(CREATED.value(), DEFAULT_MESSAGE, data);
+    public static <T> ApiResponse<T> created(T data) {
+        return new ApiResponse<>(CREATED.value(), DEFAULT_MESSAGE, data);
     }
 }