Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StreamsList): addons install button [WIP] #741

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Dec 11, 2024

  • Refactored the install button placement to two different scenarios:
  1. When core returns less than 2 Ready responses from the addons Object.keys(streamsByAddon).length < 2 && countLoadingAddons === 0 we show the big button (this is because we always get one response from WatchHub)

image

  1. When core returns more than 1 response even if they are not ready we show a smaller button at the end of the streams list to have more space on smaller devices Object.keys(streamsByAddon).length > 1

image
photo_2024-12-11_11-53-04

TODO

  • Implement core side confirmation that the user does not need the button at all (count account age, installed addons etc)

@kKaskak kKaskak added the enhancement New feature or request label Dec 11, 2024
@kKaskak kKaskak requested a review from tymmesyde December 11, 2024 09:49
@kKaskak kKaskak self-assigned this Dec 11, 2024
@kKaskak kKaskak changed the title refactor(StreamsList): addons install button refactor(StreamsList): addons install button [WIP] Dec 12, 2024
@kKaskak kKaskak marked this pull request as draft December 12, 2024 11:30
@kKaskak kKaskak added refactor refactor of existing code, code removal, etc and removed enhancement New feature or request labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor of existing code, code removal, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant