Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace single quotes in search bar as well as search history since it interferes with results. #723

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

michaelmano
Copy link

@michaelmano michaelmano commented Nov 12, 2024

When searching for media that includes single quotes the results are always incorrect.

Example Title: I'll Become a Villainess Who Goes Down in History

Searching for the above with a single quote will not return the correct results. You have to manually remove them which was quote annoying.

I am sure there is a better way to fix this than just replacing them maybe in core?
This was a way to fix it that I was able to do.

#724

search history since it interferes with results.
@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
All committers have signed the CLA.

@michaelmano michaelmano changed the title Replace single quotes in search bar as well as search history since it interferes with results. Fix: Replace single quotes in search bar as well as search history since it interferes with results. Nov 12, 2024
@michaelmano michaelmano changed the title Fix: Replace single quotes in search bar as well as search history since it interferes with results. fix: Replace single quotes in search bar as well as search history since it interferes with results. Nov 12, 2024
Copy link
Contributor

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest using replace instead of replaceAll. It should work since you are applying a regex operation.

Using replace grants much better support, including for older browsers.

@michaelmano
Copy link
Author

I would like to suggest using replace instead of replaceAll. It should work since you are applying a regex operation.

Using replace grants much better support, including for older browsers.

True, I was only thinking of the compiled desktop version. Amended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants