feat(skinned-mesh): add support for 'Child Of' constraint on bones #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible for bones in armatures to set a custom parent based on the 'Child Of' constraint target (PoseBone). Simplifies the workflow by allowing a single armature to manage all bones, instead of requiring one armature per bone. Note: With current implementation the armature need to be added outside the hierarchy at the bottom of everything you want to export
…-child-of-constraint
…roper comments for the logic
|
Matrix calc should now work as expected, added additional comments and refined the whole conversion function |
|
Probably need to do some changes to this when #238 is merged. I am also pretty sure that the approuch of the "Child Of" constrain implementaion here is not the best solution 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible for bones in armatures to set a custom parent
based on the 'Child Of' constraint target (PoseBone). Simplifies
the workflow by allowing a single armature to manage
all bones, instead of requiring one armature per bone.
Note: With current implementation the armature need to be added outside the hierarchy at the bottom of everything you want to export