[Feat]회원가입 기능 구현 #18
Merged
[Feat]회원가입 기능 구현 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHS00
approved these changes
Oct 1, 2023
This was referenced Oct 1, 2023
Merged
|
마커 인터페이스를 사용하는 이유가 궁금합니다 |
jinwooseok
reviewed
Oct 7, 2023
There was a problem hiding this comment.
toEntity를 converter로 따로 두는 이유가 있나요? dto를 entity로 변환하는데 toEntity는 dto를 entity로 변환해주는 것이니까 dto의 멤버함수로 있는게 좋지 않나요?
jinwooseok
reviewed
Oct 7, 2023
| private final ValidNicknameService validNicknameService; | ||
|
|
||
| @Transactional | ||
| public void execute(final SaveUserRequest source) { |
jinwooseok
reviewed
Oct 7, 2023
| public class ValidEmailService { | ||
| private final UserRepository userRepository; | ||
|
|
||
| public void execute(EmailSupplier supplier) { |
There was a problem hiding this comment.
supplier를 쓰는 이유? supplier가 getEmail만을 갖고 있어서 다른 부분들을 안쓰게 하면서 역할을 명확히 하려고?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 내용에 대한 PR인가요?
회원가입 기능 구현했습니다.
변경 사항
변경된 부분에 대한 상세한 내용을 나열해주세요
무엇을 위주로 보면 좋을까요?
관련된 이슈
closes (#1)
테스트 방법
테스트 코드 추가하겠습니다!