Include recurring profile reference in reauthorize requests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2017 14:24
`render :text` is no longer supported as of Rails 5.1, so this will try to render a notify.html.erb view which doesn't exist. Render plain has been supported since Rails 4.2, so this shouldn't cause any compatibility issues.
The way this is currently implemented, it will use the shopper reference to find any potential recurring payment contracts and automatically use the latest one. This can potentially cause problems and we should just use the profile reference we have stored on the credit card.
adammathys
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this is currently implemented, it will use the shopper reference to find any potential recurring payment contracts and automatically use the latest one. This can cause problems because the shopper reference we use is either the
user_idif one exists and otherwise the order number. If an order is initially placed as a guest checkout and later associated to a user, the recurring profile lookup will fail.We already store the recurring profile reference on the payment source (
Spree::CreditCard), so we should just pass in the one we have on file explicitly.