Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a Biscuit? #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

cputnam-a11y
Copy link

Sodium Stuff.
I think it works.
You should test it.

@StellarWitch7 StellarWitch7 self-assigned this Nov 24, 2024
@StellarWitch7 StellarWitch7 added the enhancement New feature or request label Nov 24, 2024
@StellarWitch7
Copy link
Owner

If we can have this tested with and targeting 0.6 stable, that'd be great.

cputnam-a11y and others added 4 commits November 25, 2024 21:31
  * Move to 0.6
  * Move from 800 copies of component per tick to 50ish?
  * move from atomic fields to volatile fields
  * make version number human-readable
  * Fix Culling Issues
  * General Cleanup
  * Remove Debug Items and Components and Keybindings
@StellarWitch7
Copy link
Owner

It appears biome colors aren't being applied; @enjarai says they work fine without Sodium. I'd appreciate if this would be resolved before merging.

@cputnam-a11y
Copy link
Author

Epic. Sodium caches the nessesary biome colors for a chunk. If I have time I'll check it out.

@StellarWitch7
Copy link
Owner

StellarWitch7 commented Nov 28, 2024

Epic. Sodium caches the nessesary biome colors for a chunk. If I have time I'll check it out.

Take your time; we're in no hurry. Progress so far is great; I've not noticed any other issues and performance doesn't appear terribly affected by anything. We'll probably be good to merge afterwards.

@cputnam-a11y
Copy link
Author

If you wouldn't mind, could you write up how you got it to not work, so I can check that?

@StellarWitch7
Copy link
Owner

If you wouldn't mind, could you write up how you got it to not work, so I can check that?

I used oak leaves as a shadow in different biomes; the result was that the oak leaves always rendered as the default colouring, even when the biome had a different tint to it. There's a spell export in a comment in Illusionist.java which you can use to test (crouching makes it pick a shadow; when not crouching it applies it). You can use /trickster importSpell to import from clipboard.

@cputnam-a11y
Copy link
Author

Screen.Recording.2024-12-02.at.2.31.38.PM.mp4

I can't seem to reproduce the issue?

@StellarWitch7
Copy link
Owner

Screen.Recording.2024-12-02.at.2.31.38.PM.mp4

I can't seem to reproduce the issue?

Oh? Strange. I'll test again.

@cputnam-a11y
Copy link
Author

🦗🦗🦗🦗🦗
🦗🕷️🕸️🏕️🦗
🦗🦗🦗🦗🦗

@StellarWitch7
Copy link
Owner

I've been busy. I'll let you know once I've gotten to it.

@cputnam-a11y
Copy link
Author

It's okay, I've been busy too. Just making sure the thread doesn't look like the graphic

@StellarWitch7
Copy link
Owner

Screen.Recording.2024-12-02.at.2.31.38.PM.mp4

I can't seem to reproduce the issue?

This is strange (these are all birch leaves).
image

@cputnam-a11y
Copy link
Author

Hmm.

@cputnam-a11y
Copy link
Author

So because I can't tell through the picture, you did manage to reproduce the problem? Or it's solved?

@StellarWitch7
Copy link
Owner

The leaves should be the same colour; they are not. I'm not sure why it is, since you don't seem to be able to reproduce...

@cputnam-a11y
Copy link
Author

I'll take a look and try it with Birch. Should I try it in that biome as well?

@StellarWitch7
Copy link
Owner

I've honestly no clue. Might be relevant. Might not be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants