-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have a Biscuit? #1
base: main
Are you sure you want to change the base?
Conversation
If we can have this tested with and targeting 0.6 stable, that'd be great. |
* Move to 0.6 * Move from 800 copies of component per tick to 50ish? * move from atomic fields to volatile fields
* make version number human-readable
* Fix Culling Issues * General Cleanup * Remove Debug Items and Components and Keybindings
It appears biome colors aren't being applied; @enjarai says they work fine without Sodium. I'd appreciate if this would be resolved before merging. |
Epic. Sodium caches the nessesary biome colors for a chunk. If I have time I'll check it out. |
Take your time; we're in no hurry. Progress so far is great; I've not noticed any other issues and performance doesn't appear terribly affected by anything. We'll probably be good to merge afterwards. |
If you wouldn't mind, could you write up how you got it to not work, so I can check that? |
I used oak leaves as a shadow in different biomes; the result was that the oak leaves always rendered as the default colouring, even when the biome had a different tint to it. There's a spell export in a comment in |
Screen.Recording.2024-12-02.at.2.31.38.PM.mp4I can't seem to reproduce the issue? |
Oh? Strange. I'll test again. |
🦗🦗🦗🦗🦗 |
I've been busy. I'll let you know once I've gotten to it. |
It's okay, I've been busy too. Just making sure the thread doesn't look like the graphic |
Hmm. |
So because I can't tell through the picture, you did manage to reproduce the problem? Or it's solved? |
The leaves should be the same colour; they are not. I'm not sure why it is, since you don't seem to be able to reproduce... |
I'll take a look and try it with Birch. Should I try it in that biome as well? |
I've honestly no clue. Might be relevant. Might not be. |
Sodium Stuff.
I think it works.
You should test it.