Fix for Issue 2 - dropped ACKs #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop dropping all ACKs that don't correlate with an existing transaction - 2xx ACKs are their own transaction, so it's up to the dialog logic to sort them out.
|
retest this please |
rynorris
requested changes
Nov 2, 2016
| // don't engender a provisional response - we just pass them up to the user | ||
| // to handle at the dialog scope. | ||
| mng.sendPresumptiveTrying(tx) | ||
| } |
There was a problem hiding this comment.
This section is indented with spaces instead of tabs. You monster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop dropping all ACKs that don't correlate with an existing transaction - 2xx ACKs are their own transaction, so it's up to the dialog logic to sort them out.
@DiscoViking , I'm not super familiar with the code here and the transaction logic is mostly untested, so can you either: