-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/#1312 add in distributed tracing #1313
base: release/3.2
Are you sure you want to change the base?
Enhancement/#1312 add in distributed tracing #1313
Conversation
I don't see the point of adding this, am I missing something? ASP.NET already provides built-in tracing for HttpClient usage. |
Without this change the log messages being generated by steeltoe do not have the tracing properties (trace, transaction & span) hence I was ending up with alot of messages missing the tracing properties. Note most of the changes are whitespace due to introduction of the using statements. |
How are tracing properties useful on these items? These interactions are typically called in the background rather than as a part of any distributed interaction. |
So what i was noticing is that for example the background requests to eureka server, i was not able to correlate the logs being generated prior to the http requests with the server processing of the request and at the same time was not able to connect the processing of the response to the original request. |
I don't understand why a periodic background request to eureka should be correlated to an incoming request. There's no relationship between those execution flows. For example: 18:43:01 Incoming HTTP request at /api/shoppingbasket, correlation ID matching click in UI |
The reason for me is so that the logs generated prior to the transmission ie 18:43:09 Outgoing eureka request Can be correlated through the logs as the request traverses the environment ie via a reverse proxy/load balancer & then ideally your eureka/consul server etc. At the same time there was some endpoints which weren't generating activities. |
ab06346
to
444e26c
Compare
Description
To improve traceability activities are now being created so that external requests can be traced
Closes #1312
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.