Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Messaging/Stream/Integration/SpEL #1246

Merged
merged 35 commits into from
Jan 12, 2024

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Jan 11, 2024

Description

Following up on the announcement at #1244, this PR removes several Steeltoe components:

  • Steeltoe.Messaging
  • Steeltoe.Stream
  • Steeltoe.Integration
  • Steeltoe.Common.Expression (SpEL)
  • Several parts in Steeltoe.Common that were used only by the above (see individual commits)

Additionally, adds test projects for Prometheus and Wavefront to the solution that existed on disk but were not included.

#1221, #1014, #980, #907, #906, #903, #838, #789, #775, #749, #739, #649, #601, #582, #487, #400, #392, #336, #300, #242, #133, #132.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware
Copy link
Member Author

bart-vmware commented Jan 11, 2024

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bart-vmware bart-vmware marked this pull request as ready for review January 11, 2024 20:49
@bart-vmware bart-vmware requested a review from TimHess January 11, 2024 20:49
@bart-vmware bart-vmware added Component/Common Component/Stream Issues related to Steeltoe Stream Component/Messaging ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jan 11, 2024
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove IApplicationContext, ILifecycle and everything stemming from Common.Abstractions/Retry and then this round will be done

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bart-vmware bart-vmware requested a review from TimHess January 12, 2024 09:02
@bart-vmware bart-vmware merged commit f57f360 into main Jan 12, 2024
18 checks passed
@bart-vmware bart-vmware deleted the drop-messaging-stream-integration-spel branch January 12, 2024 16:25
@TimHess TimHess added this to the 4.0.0-m1 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Common Component/Messaging Component/Stream Issues related to Steeltoe Stream ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants