Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connector support for VMware Postgres TAS tile #1212

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Nov 1, 2023

Description

Add Connector support for the PostgreSQL TAS tile at https://docs.vmware.com/en/VMware-Postgres-for-VMware-Tanzu-Application-Service/1.0/postgres/index.html.

Update (dec 2023): reverted back to draft, due to potential upcoming changes in the postgres vmware tile.

The problem: High Availability mode does not work, because the tile uses bosh for load-balancing. Despite credentials:hosts being an array, it will currently always contain a single entry (to bosh). A subsequent DNS resolve results in multiple IPs, which Npgsql does not support.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware marked this pull request as ready for review November 1, 2023 12:04
@TimHess TimHess added this to the 4.0.0-m1 milestone Nov 1, 2023
@TimHess TimHess added Type/enhancement New feature or request Component/Configuration Issues related to Configuration providers Component/Connectors Issues related to Steeltoe connectors ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Nov 1, 2023
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware force-pushed the connectors-postgresql-vmware branch from 9b0a47a to d52706e Compare November 8, 2023 16:40
@bart-vmware bart-vmware force-pushed the connectors-postgresql-vmware branch from d52706e to 16c738b Compare December 1, 2023 14:49
@bart-vmware bart-vmware marked this pull request as draft December 1, 2023 14:49
@bart-vmware bart-vmware force-pushed the connectors-postgresql-vmware branch from 16c738b to 9e4213f Compare December 20, 2023 12:30
@TimHess TimHess removed this from the 4.0.0-m1 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Configuration Issues related to Configuration providers Component/Connectors Issues related to Steeltoe connectors ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants