Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-target Steeltoe against .NET 6/8 #1207

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Multi-target Steeltoe against .NET 6/8 #1207

merged 9 commits into from
Nov 23, 2023

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Oct 19, 2023 •
edited
Loading

Description

Adds multi-targeting against the RTM versions of .NET 6 and 8.

Currently blocked by https://youtrack.jetbrains.com/issue/RSRP-494775/InspectCode-CleanupCode-hangs-on-.NET-8-RTM.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware force-pushed the multi-target-net80 branch 2 times, most recently from 1a7ba46 to dde4a31 Compare October 20, 2023 12:13
@bart-vmware
Copy link
Member Author

bart-vmware commented Oct 20, 2023 •
edited
Loading

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 30 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bart-vmware bart-vmware force-pushed the multi-target-net80 branch 3 times, most recently from 29dcc16 to 763ccf3 Compare October 23, 2023 13:36
@bart-vmware bart-vmware marked this pull request as ready for review October 23, 2023 15:15
TimHess
TimHess previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cleanupcode.ps1 Show resolved Hide resolved
shared.props Outdated Show resolved Hide resolved
TimHess
TimHess previously approved these changes Oct 30, 2023
View reviewed changes
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bart-vmware bart-vmware requested a review from TimHess November 22, 2023 14:46
TimHess
TimHess approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bart-vmware bart-vmware merged commit f6d2dda into main Nov 23, 2023
28 checks passed
@bart-vmware bart-vmware deleted the multi-target-net80 branch November 23, 2023 11:59
@TimHess TimHess added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Dec 8, 2023
@TimHess TimHess added this to the 4.0.0-m1 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess approved these changes

Assignees
No one assigned
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging this pull request may close these issues.
2 participants
@bart-vmware @TimHess