fix(heartbeat): move check URL to top level of resource #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbasham
force-pushed
the
fix-heartbeat-monitoring-resource
branch
from
32d4670 to
9dfd87e
Compare
Unlike other resource the Heartbeat resource does not accept a URL or hostname as an input parameter. This meant that having it inside of `monitored_resource` made little sense and was causing issues due to the check URL being computed.
tomasbasham
force-pushed
the
fix-heartbeat-monitoring-resource
branch
from
c03af97 to
6c12c77
Compare
bravoecho
approved these changes
Sep 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other resource the Heartbeat resource does not accept a URL or hostname as an input parameter. This meant that having it inside of
monitored_resourcemade little sense and was causing issues due to the check URL being computed.