Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure header footer #16

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AutomateAaron
Copy link
Collaborator

This PR adds the following configuration options to the config.toml:

footerButtonTarget = "/contact"
footerButtonText = "Get in Touch"
footerCallToAction = "Let's Start a Project"
footerTopTitle = "Contact me"

headerButtonTarget = "/contact"
headerButtonText = "Hire Me Now"

@AutomateAaron
Copy link
Collaborator Author

@kausarpial also, I'm happy to merge any conflicts between these branches if you can just give a ✔️ on the reviews.

@kausarpial
Copy link
Contributor

@kausarpial also, I'm happy to merge any conflicts between these branches if you can just give a ✔️ on the reviews.

Hi @AaronNBrock,
Please use absURL in the links and please remove / from the front of the links. Otherwise, it won't work on the live link on themes.gohugo.io.

@AutomateAaron
Copy link
Collaborator Author

@kausarpial I was following example on the hugo documentation

The URLs must be relative to the context root. If the baseURL is https://example.com/mysite/, then the URLs in the menu must not include the context root mysite. Using an absolute URL will override the baseURL. If the value used for URL in the above example is https://subdomain.example.com/, the output will be https://subdomain.example.com.

Using absURL strips off the #id from the links which breaks the smoothscrolling, do you know if relURL would work?

@kausarpial
Copy link
Contributor

@kausarpial I was following example on the hugo documentation

The URLs must be relative to the context root. If the baseURL is https://example.com/mysite/, then the URLs in the menu must not include the context root mysite. Using an absolute URL will override the baseURL. If the value used for URL in the above example is https://subdomain.example.com/, the output will be https://subdomain.example.com.

Using absURL strips off the #id from the links which breaks the smoothscrolling, do you know if relURL would work?

Yeah, I also face that kind of problem for the #id. I think we should compromise that. Because it's hosted on a directory in the themes.gohugo.io instead of a subdomain.
Let me know if you find a better solution.

@AutomateAaron
Copy link
Collaborator Author

How do other themes do it? I feel we can't be the first to come across this issue.

@kausarpial
Copy link
Contributor

Can you suggest a theme with that functionality? It'd be great if we can do that.
I'll also do some research on that too.

@AutomateAaron
Copy link
Collaborator Author

This theme: hugo-profile

Is using {{ .Url }} w/o any relURL or absURL: header.html#L28

For reference, this is how the item is defined: config.yaml#L34

And is seems to work okay on the demo page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants