Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vuln): Update base image #75

Merged
merged 1 commit into from
Feb 2, 2022
Merged

fix(vuln): Update base image #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/build-centraldashboard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ jobs:
${{ env.REGISTRY_NAME }}.azurecr.io/kubeflow/centraldashboard:${GITHUB_REF#refs/*/}
docker push ${{ env.REGISTRY_NAME }}.azurecr.io/kubeflow/centraldashboard:${GITHUB_REF#refs/*/}

# Comment out for now while https://github.com/Azure/container-scan/issues/122 is still open
# ALSO should re-order this to actuall have it block the push if there is a critical severity
# Scan image for vulnerabilities
- uses: Azure/container-scan@v0
with:
image-name: ${{ env.REGISTRY_NAME }}.azurecr.io/kubeflow/centraldashboard:${{ github.sha }}
severity-threshold: CRITICAL
run-quality-checks: false
#- uses: Azure/container-scan@v0
# with:
# image-name: ${{ env.REGISTRY_NAME }}.azurecr.io/kubeflow/centraldashboard:${{ github.sha }}
# severity-threshold: CRITICAL
# run-quality-checks: false
4 changes: 2 additions & 2 deletions components/centraldashboard/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Step 1: Builds and tests
FROM node:12.22.8-alpine AS build
FROM node:16-alpine AS build

ARG kubeflowversion
ARG commit
Expand Down Expand Up @@ -40,7 +40,7 @@ RUN npm rebuild && \
npm prune --production

# Step 2: Packages assets for serving
FROM node:12.22.8-alpine AS serve
FROM node:16-alpine AS serve

ENV NODE_ENV=production
WORKDIR /app
Expand Down
Loading