Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat french pages #1870

Merged
merged 15 commits into from
Nov 2, 2023
Merged

Feat french pages #1870

merged 15 commits into from
Nov 2, 2023

Conversation

wg102
Copy link
Contributor

@wg102 wg102 commented Oct 31, 2023

Closes #1850

@mathis-marcotte mathis-marcotte self-requested a review October 31, 2023 17:47
@chuckbelisle chuckbelisle self-requested a review November 1, 2023 12:53
@chuckbelisle
Update Gitlab.md
cba6a11 
missed translation for access token
chuckbelisle
chuckbelisle previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@chuckbelisle chuckbelisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Section 5, 6 and 7 look great, good work! I left a comment about docs/fr/7-MLOps/sklearn_iris_jsondata.ipynb being reverted back to English

mathis-marcotte
mathis-marcotte requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments I reviewed the /en changes, as well as the /fr cahnges excluding the section 5,6 and 7.

docs/fr/1-Experiences/Apercu.md Outdated Show resolved Hide resolved
docs/fr/1-Experiences/Apercu.md Outdated Show resolved Hide resolved
docs/fr/1-Experiences/Bureau-virtuel.md Outdated Show resolved Hide resolved
docs/fr/1-Experiences/Bureau-virtuel.md Outdated Show resolved Hide resolved
docs/fr/1-Experiences/Bureau-virtuel.md Outdated Show resolved Hide resolved
docs/fr/4-Collaboration/Aperçu.md Show resolved Hide resolved
docs/fr/4-Collaboration/Demander-EspaceDeNom.md Show resolved Hide resolved
docs/fr/4-Collaboration/Demander-EspaceDeNom.md Outdated Show resolved Hide resolved
docs/fr/4-Collaboration/Environnement-Analyse-Geospatiale.md Outdated Show resolved Hide resolved
docs/fr/4-Collaboration/Environnement-Analyse-Geospatiale.md Outdated Show resolved Hide resolved
mathis-marcotte
mathis-marcotte requested changes Nov 2, 2023
View reviewed changes
docs/fr/1-Experiences/Kubeflow.md Outdated Show resolved Hide resolved
docs/fr/1-Experiences/Kubeflow.md Outdated Show resolved Hide resolved
docs/fr/3-Pipelines/Argo.md Outdated Show resolved Hide resolved
docs/fr/4-Collaboration/Environnement-Analyse-Geospatiale.md Outdated Show resolved Hide resolved
@wg102 wg102 merged commit a9e9acb into master Nov 2, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathis-marcotte mathis-marcotte mathis-marcotte approved these changes

@chuckbelisle chuckbelisle chuckbelisle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync both official languages for user wiki
3 participants
@wg102 @chuckbelisle @mathis-marcotte