feat(workflows): integrate hadolint (dockle failed)

[Jose-Matsuda]

Description

What your PR adds/fixes/removes
Leverage Dockle, nothing else, will need to determine when we want to fail

Tests / Quality Checks

Are there breaking changes?

Ask yourself the next question;

• Do we want to maintain the previous image from which we had to do breaking changes from?

If no, then carry on. If yes, there is a breaking change and we want to maintain the previous image do the following

• Create a new branch for the current version (ex v1) based off the current master/main branch
• Increment the tag in the CI for pushes to master/main (v1 to v2)
• Change the CI that on pushes to the newly created "v1" branch (the name of the newly created branch we want to maintain is) it will push to the ACR.

Automated Testing/build and deployment

• Does the image pass CI successfully (build, pass vulnerability scan, and pass automated test suite)?
• If new features are added (new image, new binary, etc), have new automated tests been added to cover these?
• If new features are added that require in-cluster testing (e.g. a new feature that needs to interact with kubernetes), have you added the auto-deploy tag to the PR before pushing in order to build and push the image to ACR so you can test it in cluster as a custom image?

JupyterLab extensions

• Are all extensions "enabled" (jupyter labextension list from inside the notebook)?

VS Code tests

• Does VS Code open?
• Can you install extensions?

Code review

• Have you added the auto-deploy tag to your PR before your most recent push to this repo? This causes CI to build the image and push to our ACR, letting reviewers access the built image without having to create it themselves
• Have you chosen a reviewer, attached them as a reviewer to this PR, and messaged them with the SHA-pinned image name for the final image to test on the dev cluster (e.g. k8scc01covidacrdev.azurecr.io/jupyterlab-cpu:746d058e2f37e004da5ca483d121bfb9e0545f2b)?

[Jose-Matsuda]

Similar to Pat, some of the images are just failing building (and I definitely did not touch anything that should affect that).

So I compared the Dockerfiles for one of the images that fail to build in this current workflow this run from 3 weeks ago](https://github.com/StatCan/aaw-kubeflow-containers/actions/runs/5587354004/job/15131793911) and the sas dockerfile itself has not changed in 3 weeks and was successful (as were all the other images) in pushing

Even two weeks ago when I approved Bryan's PR
everything built fine

[Jose-Matsuda]

Our nightly build pushes also happen to correspond with the merging of that PR somehow.

(note that the middle one of the 3rd was cancelled by Pat (but I think this would have succeeded anyways)

Bryan's PR was merged in August 4th and the nightly build then failed;

but I still dont understand why

[Jose-Matsuda]

I dont understand this https://github.com/StatCan/aaw-kubeflow-containers/actions/runs/5952108859/job/16143335555

vs

As in we have cases where it succeeds and doesnt produce an error, but another where it will just die on trying to pull...

[Jose-Matsuda]

even changing from localhost to just the tag of just jupyterlab-pytorch:sha does not work :/

Souheil advised doing a tar thing as in here
I was looking into doing something with xargs but cant really do it I think / cant avoid doing a docker save to a tar file (we cant just use the input).

something like echo "-v" | xargs -I{} curl google.com {} could have been adapted for our use case here if it would take input.

[Jose-Matsuda]

Trying hadolint, it seems to have failed for the same reason though I thought it just ran on the Dockerfile definition and NOT the image....

[mathis-marcotte]

lgtm