Skip to content

Commit

Permalink
Update build_push.yaml: deprecate set-output (#491)
Browse files Browse the repository at this point in the history
* Update build_push.yaml: deprecate set-output

update workflow to use $GITHUB_OUTPUT instead of set-output.

See: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* Update build_push.yaml: update syntax

* Update build_push.yaml: update syntax for interpolation

* Update build_push.yaml: change notebook name variable name

* update remaining set-output commands

* Update Makefile: reset set-output commands for Makefile

Github Actions was complaining about set-output in the Makefile but I think we have to leave these lines alone since they are used by Make and not by Github Actions.
  • Loading branch information
bryanpaget authored and Bryan Paget committed Aug 22, 2023
1 parent f3c6e71 commit 186ed8d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
id: notebook-name
shell: bash
run: |
echo ::set-output name=NOTEBOOK_NAME::${{ matrix.notebook }}
echo NOTEBOOK_NAME=${{ matrix.notebook }} >> $GITHUB_OUTPUT
# Connect to Azure Container registry (ACR)
- uses: azure/docker-login@v1
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
github.event_name == 'pull_request' &&
contains( github.event.pull_request.labels.*.name, 'auto-deploy')
)
run: echo "::set-output name=boolean::true"
run: echo 'boolean=true' >> $GITHUB_OUTPUT

# Pull the local image back, then "build" it (will just tag the pulled image)
- name: Pull image back from local repo
Expand Down
1 change: 0 additions & 1 deletion make_helpers/get_branch_name.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ if [[ $GITHUB_ACTIONS == "true" ]] ; then
BRANCH_NAME=""
fi

# echo "::set-output name=branch_name::$BRANCH_NAME"
else
BRANCH_NAME=`git rev-parse --abbrev-ref HEAD`
fi
Expand Down

0 comments on commit 186ed8d

Please sign in to comment.