Skip to content

Commit

Permalink
Fix rows outside table
Browse files Browse the repository at this point in the history 
Problem: As mentioned in the review, the rows were displayed outside of the table.
Solution: Remove dom-repeat tags that were inside dom-if tags.
  • Loading branch information
Mihai committed Aug 14, 2017
1 parent 1c8531a commit 09b0743
Showing 1 changed file with 22 additions and 26 deletions.
48 changes: 22 additions & 26 deletions index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,17 @@
</tr>
</thead>
<tbody>
<dom-repeat>
<template is="dom-repeat" items="{{model.files}}">
<tr>
<td>{{item.file.name}}</td>
<td>{{item.file.type}}</td>
<td>{{item.sizeString}}</td>
<td>
<span>{{item.progress}}</span>%
</td>
<td>{{item.error}}</td>
</tr>
</template>
</dom-repeat>
<template is="dom-repeat" items="{{model.files}}">
<tr>
<td>{{item.file.name}}</td>
<td>{{item.file.type}}</td>
<td>{{item.sizeString}}</td>
<td>
<span>{{item.progress}}</span>%
</td>
<td>{{item.error}}</td>
</tr>
</template>
</tbody>
</table>
</template>
Expand All @@ -79,19 +77,17 @@ <h4>The <code>starcounter-upload.tasks</code> collection</h4>
</tr>
</thead>
<tbody>
<dom-repeat>
<template is="dom-repeat" items="{{tasks}}">
<tr>
<td>{{item.file.name}}</td>
<td>{{item.file.type}}</td>
<td>{{item.sizeString}}</td>
<td>
<span>{{item.progress}}</span>%
</td>
<td>{{item.error}}</td>
</tr>
</template>
</dom-repeat>
<template is="dom-repeat" items="{{tasks}}">
<tr>
<td>{{item.file.name}}</td>
<td>{{item.file.type}}</td>
<td>{{item.sizeString}}</td>
<td>
<span>{{item.progress}}</span>%
</td>
<td>{{item.error}}</td>
</tr>
</template>
</tbody>
</table>
</template>
Expand Down

0 comments on commit 09b0743

Please sign in to comment.