[Enhancement] Upgrade paimon sdk to 1.0 version #54796
Open
+41
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
| return true; | ||
| } catch (Catalog.TableNotExistException e) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
The most risky bug in this code is:
Improper handling of exceptions which might lead to incorrect flow if unexpected exceptions occur.
You can modify the code like this:
public Database getDb(String dbName) {
if (databases.containsKey(dbName)) {
return databases.get(dbName);
}
try {
// get database from paimon catalog to see if the database exists
paimonNativeCatalog.getDatabase(dbName);
Database db = new Database(CONNECTOR_ID_GENERATOR.getNextId().asInt(), dbName);
databases.put(dbName, db);
return db;
} catch (Catalog.DatabaseNotExistException e) {
LOG.error("Paimon database {}.{} does not exist.", catalogName, dbName);
return null;
} catch (Exception e) {
LOG.error("An unexpected error occurred while fetching the database: {}", e.getMessage());
return null; // or throw a more specific custom exception as needed
}
}
mxdzs0612
changed the title
mxdzs0612
changed the title
mxdzs0612
force-pushed
the
paimon_systable
branch
2 times, most recently
from
7ebadaa to
6d31175
Compare
[FE Incremental Coverage Report]❌ fail : 3 / 6 (50.00%) file detail
|
Signed-off-by: Jiao Mingye <[email protected]>
mxdzs0612
force-pushed
the
paimon_systable
branch
from
6d31175 to
8d2dae2
Compare
|
[Java-Extensions Incremental Coverage Report]coverage check fail. please retry. 😨 Please let me know when error again. com.naver.nid.cover.parser.coverage.exception.ParseException: java.nio.file.NoSuchFileException: /home/runner/_work/starrocks/starrocks/java-extensions/result |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: