Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]Abstract out the logictype-independent RawColumnReader for future optimization #54675

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Jan 3, 2025

Why I'm doing:

After refactoring, RawColumnReader is independent of logictype and is responsible
for reading the raw data files, returning the most original column. The upper layer
can perform type conversions, global low cardinality mappings, and even expression
calculations to generate new columns. Meanwhile, the metadata related code and
the code for target type convert/decode have been separated, making delayed
convert/decode clearer.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@zombee0 zombee0 requested a review from a team as a code owner January 3, 2025 07:29
@mergify mergify bot assigned zombee0 Jan 3, 2025
@DorianZheng
Copy link
Contributor

Please describe the reason for this refactor

Copy link

github-actions bot commented Jan 3, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 3, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 3, 2025

[BE Incremental Coverage Report]

pass : 111 / 113 (98.23%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/formats/parquet/scalar_column_reader.cpp 88 90 97.78% [289, 297]
🔵 be/src/formats/parquet/scalar_column_reader.h 23 23 100.00% []

@zombee0
Copy link
Contributor Author

zombee0 commented Jan 3, 2025

Please describe the reason for this refactor

After refactoring, RawColumnReader is independent of logictype and is responsible for reading the raw data files, returning the most original column. The upper layer can perform type conversions, global low cardinality mappings, and even expression calculations to generate new columns. Meanwhile, the logic for reading and the logic for delayed convert/decode have been separated, making delayed convert/decode clearer.

@dirtysalt dirtysalt merged commit 7ebbf7e into StarRocks:main Jan 3, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants