Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix wrong plan when apply offset limit in PushDown Project limit #54654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Jan 3, 2025

Why I'm doing:

for such query:

select count(*) from (select c0 from (   select * from (   select c0, c1 from tx3 order by c0 asc limit 1000, 600   ) l  union all select 0 as c0, '0' as c1 ) b limit 100)t;

the local sort expected limit with 1100.

  2:TOP-N
  |  order by: <slot 1> 1: v1 ASC
  |  offset: 0
  |  limit: 1100
  |  
  1:OlapScanNode
     TABLE: t0
     PREAGGREGATION: ON
     partitions=0/1
     rollup: t0
     tabletRatio=0/0
     tabletList=
     cardinality=1
     avgRowSize=1.0

but we got a limit 100

  2:TOP-N
  |  order by: <slot 1> 1: v1 ASC
  |  offset: 0
  |  limit: 100
  |  
  1:OlapScanNode
     TABLE: t0
     PREAGGREGATION: ON
     partitions=0/1
     rollup: t0
     tabletRatio=0/0
     tabletList=
     cardinality=1
     avgRowSize=1.0

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@stdpain stdpain requested a review from a team as a code owner January 3, 2025 06:10
@mergify mergify bot assigned stdpain Jan 3, 2025
kangkaisen
kangkaisen previously approved these changes Jan 3, 2025
Signed-off-by: stdpain <[email protected]>
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Jan 3, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 3, 2025

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/PushDownProjectLimitRule.java 2 2 100.00% []

Copy link

github-actions bot commented Jan 3, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants