Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Remove unnecessary frequent memory alloc and release requests #54604

Merged
merged 4 commits into from
Jan 3, 2025
Merged

[Enhancement] Remove unnecessary frequent memory alloc and release requests #54604

merged 4 commits into from
Jan 3, 2025

Conversation

sevev
Copy link
Contributor

@sevev sevev commented Jan 2, 2025 •
edited
Loading

Why I'm doing:

There are frequent memory alloc and release request during compress a shard of pindex file which is not necessary. And it may cause more cpu cost.
image

What I'm doing:

Remove unnecessary and frequent memory alloc and release requests
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@sevev sevev requested a review from a team as a code owner January 2, 2025 12:33
@mergify mergify bot assigned sevev Jan 2, 2025
sevev added 2 commits January 2, 2025 21:09
@sevev
format
1d1d3a3 
Signed-off-by: sevev <[email protected]>
@sevev
update
6252515 
Signed-off-by: sevev <[email protected]>
@sevev
update
3f0c10d 
Signed-off-by: sevev <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/persistent_index.cpp 2 2 100.00% []

@sevev sevev changed the title [Enhancement] Remove unnecessary and frequent memory alloc and release requests [Enhancement] Remove unnecessary frequent memory alloc and release requests Jan 3, 2025
@wyb wyb merged commit 2fada18 into StarRocks:main Jan 3, 2025
60 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 3, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@sevev @mergify
[Enhancement] Remove unnecessary frequent memory alloc and release re…
8672916 
…quests (#54604)

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 2fada18)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@sevev @mergify
[Enhancement] Remove unnecessary frequent memory alloc and release re…
8e6e782 
…quests (#54604)

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 2fada18)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@sevev @mergify
[Enhancement] Remove unnecessary frequent memory alloc and release re…
655a49a 
…quests (#54604)

Signed-off-by: sevev <[email protected]>
(cherry picked from commit 2fada18)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @sevev
[Enhancement] Remove unnecessary frequent memory alloc and release re…
85f0d5a 
…quests (backport #54604) (#54659)

Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @sevev
[Enhancement] Remove unnecessary frequent memory alloc and release re…
03a5265 
…quests (backport #54604) (#54658)

Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @sevev
[Enhancement] Remove unnecessary frequent memory alloc and release re…
6f315d3 
…quests (backport #54604) (#54657)

Co-authored-by: zhangqiang <[email protected]>
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@sevev
[Enhancement] Remove unnecessary frequent memory alloc and release re…
270bdf1 
…quests (StarRocks#54604)

Signed-off-by: sevev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata left review comments

@wyb wyb wyb approved these changes

@decster decster decster approved these changes

Assignees

@sevev sevev

Labels
3.2-merged 3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevev @decster @wyb @alvin-celerdata