[Enhancement] add sv cbo_max_reorder_node_use_greedy and skip DP and greedy reorder without unknown stats #54593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…greedy reorder without unknown stats Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
Signed-off-by: zihe.liu <[email protected]>
ZiheLiu
force-pushed
the
fix/main/push_down_agg_broadcast_reorder
branch
from
2515670 to
92f48e7
Compare
Seaven
approved these changes
Jan 2, 2025
|
stephen-shelby
approved these changes
Jan 2, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 7 / 8 (87.50%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…greedy reorder without unknown stats (#54593) Signed-off-by: zihe.liu <[email protected]> (cherry picked from commit b570cd1)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Jan 2, 2025
…greedy reorder without unknown stats (backport #54593) (#54605) Co-authored-by: zihe.liu <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Jan 2, 2025
…greedy reorder without unknown stats (backport #54593) (#54605) Co-authored-by: zihe.liu <[email protected]> (cherry picked from commit 2b8c522)
maggie-zhu
pushed a commit
to maggie-zhu/starrocks
that referenced
this pull request
Jan 6, 2025
…greedy reorder without unknown stats (StarRocks#54593) Signed-off-by: zihe.liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Add Session Variable
cbo_max_reorder_node_use_greedyWhen there are approximately 20 join nodes, the greedy join reorder can also consume significant time. For instance, in TPC-DS Q64,
JoinReorderGreedytakes 600ms. Additionally,cbo_push_down_aggregate_on_broadcast_jointriggers an extra join reorder during the RBO stage, increasing query latency by 600ms.Therefore, introduce a session variable
cbo_max_reorder_node_use_greedy(16 by default) .skip DP and greedy reorder without unknown stats for
cbo_push_down_aggregate_on_broadcast_joinThe
ReorderJoinRule::rewritemethod lacks a critical piece of logic compared toReorderJoinRule::transform: skipping DP and greedy reorder when certain column statistics areunknown. This omission causeshive_tpcds.query17.sqlto regress.What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/8933
Test
Environment
There is not query degression, and Q64 from 9911ms to 6188ms.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: