Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] patching flatbuffers CMakeLists.txt #54579

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Jan 2, 2025

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai kevincai requested a review from a team as a code owner January 2, 2025 04:58
@github-actions github-actions bot added the 3.4 label Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 2, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@kevincai kevincai enabled auto-merge (squash) January 2, 2025 08:06
@kevincai kevincai merged commit f0568fd into StarRocks:main Jan 2, 2025
45 checks passed
Copy link

github-actions bot commented Jan 2, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 2, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 2, 2025
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit f0568fd)
@kevincai kevincai deleted the patch-flatbuffers-cmakelist branch January 6, 2025 02:09
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants